Add support for setting sensor parameters externally #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, congratulations on your paper publication! Targetless calibration for LiDAR-IMU systems is very interesting for a number of applications. I have been working on a LiDAR-IMU calibration pipeline myself, and as you mention in your paper, there is a lack of open-sourced packages for this problem. I would personally like to thank you for your contribution to the community.
I have been using your tool to get a reliable calibration, and plan to use it to benchmark my own algorithm.
I would like to contribute to your project by allowing the user to externally set the gyroscope/accelerometer noise densities, LiDAR noise and IMU rate, so that the optimization weights may be computed according to the user's specific sensors.
The proposed changes in this pull request include:
Tested in Ubuntu 18.04